feat(cmd): add valkey-console - #1245
Merged
Merged
Conversation
EtienneM
force-pushed
the
feat/STORY-4240/valkey-console
branch
2 times, most recently
from
August 7, 2026 08:22
2d53891 to
b3790ed
Compare
EtienneM
force-pushed
the
feat/STORY-4240/valkey-console
branch
from
September 1, 2026 13:05
b3790ed to
4c8a8f2
Compare
EtienneM
marked this pull request as ready for review
September 1, 2026 13:09
EtienneM
requested review from
a team,
briceamen and
curzolapierre
and removed request for
a team and
briceamen
September 1, 2026 13:36
curzolapierre
approved these changes
Sep 1, 2026
curzolapierre
left a comment
curzolapierre
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the different improvements!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the opportunity to also include commit 2d53891 to make lots of functions private. Let me know if you prefer I keep this commit out of this PR.
I also had to fix some new linter offenses in d29e90d
Related to STORY-4240